<p></p>
<p><b>@kcne</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5402#discussion_r1914768315">app/assets/javascripts/heatmap.js</a>:</p>
<pre style='color:#555'>> +function getThemeFromColorScheme(colorScheme) {
+  if (colorScheme === "auto") {
+    return window.matchMedia("(prefers-color-scheme: dark)").matches ? "dark" : "light";
+  }
+  return colorScheme; // Return "light" or "dark" directly if specified
+}
</pre>
<p dir="auto">I appreciate your feedback <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/hlfan/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/hlfan">@hlfan</a>. From my understanding, the primary issue was that when the “Auto” option is enabled, changes in the system’s prefers-color-scheme weren’t being reflected. With the new matchMedia logic, however, we’re directly listening for those changes, which triggers a re-draw of the heatmap whenever the user’s color scheme switches.</p>
<p dir="auto">If you’re still seeing a scenario where the theme isn’t updating correctly, please let me know so I can investigate further. Otherwise, the current solution should correctly handle automatic theme changes.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5402#pullrequestreview-2549629222">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLO5XINGDCBJBPS3L5T2KUCOPAVCNFSM6AAAAABTWNRZO6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKNBZGYZDSMRSGI">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLNKOQFQDABWGBJLEXT2KUCOPA5CNFSM6AAAAABTWNRZO6WGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUX7BASM.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5402/review/2549629222</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5402#pullrequestreview-2549629222",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5402#pullrequestreview-2549629222",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>