<p></p>
<blockquote>
<p dir="auto">As it stands this only works correctly for the transport layer that has a dark variant - for all other layers it disables the filtering when in dark mode.</p>
</blockquote>
<p dir="auto">I think it's important here to note that we decided in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2661819843" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/5328" data-hovercard-type="issue" data-hovercard-url="/openstreetmap/openstreetmap-website/issues/5328/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/issues/5328">#5328</a> that only filters approved by the cartographers should be applied. Since currently no cartographers have chosen any filters, then it's expected that any existing filtering (e.g. <code class="notranslate">darken</code>) would be removed by default, until we hear back from some other cartographers.</p>
<p dir="auto"><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/hlfan/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/hlfan">@hlfan</a> could you also work on the point that <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/tomhughes/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/tomhughes">@tomhughes</a> raised with regards to setting classes instead of using inline styles?</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5426#issuecomment-2593558235">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLOVJ3DGK2CKXIOBEDD2K2MHJAVCNFSM6AAAAABT7CQ4MWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJTGU2TQMRTGU">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLNUV5BPBG5BP7CEXGD2K2MHJA5CNFSM6AAAAABT7CQ4MWWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTU2S2HNW.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5426/c2593558235</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5426#issuecomment-2593558235",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5426#issuecomment-2593558235",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>