<p></p>
<p><b>@AntonKhorev</b> requested changes on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5474#discussion_r1918595163">app/assets/javascripts/leaflet.map.js</a>:</p>
<pre style='color:#555'>> this.addLayer(this.baseLayers[i]);
} else {
+ baselayerChanged = this.hasLayer(this.baseLayers[i]);
</pre>
<p dir="auto"><code class="notranslate">baselayerchange</code> is supposed to be fired <em>once</em> for the layer that became visible. It's not supposed to be fired for removed layers. See that <code class="notranslate">null</code> in Leafet code?<br>
<a href="https://github.com/Leaflet/Leaflet/blob/c511e66c20dce06ac05c43cf287b3ecdba00d924/src/control/Control.Layers.js#L317-L319">https://github.com/Leaflet/Leaflet/blob/c511e66c20dce06ac05c43cf287b3ecdba00d924/src/control/Control.Layers.js#L317-L319</a></p>
<p dir="auto">"This event would be triggered after the other layer events, and it would include a layer property set to the resulting base layer." <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="7531614" data-permission-text="Title is private" data-url="https://github.com/Leaflet/Leaflet/issues/1064" data-hovercard-type="pull_request" data-hovercard-url="/Leaflet/Leaflet/pull/1064/hovercard" href="https://github.com/Leaflet/Leaflet/pull/1064">Leaflet/Leaflet#1064</a></p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5474#pullrequestreview-2556220374">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLMUPWO2NCXCR3NGGDL2K62VBAVCNFSM6AAAAABUVSY6FWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKNJWGIZDAMZXGQ">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLOPXQPWPTV3MXTFN3L2K62VBA5CNFSM6AAAAABUVSY6FWWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUYLTJ5M.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5474/review/2556220374</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5474#pullrequestreview-2556220374",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5474#pullrequestreview-2556220374",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>