<p dir="auto">A new version of <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1896736892" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/4248" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/4248/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/4248">#4248</a>.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/openstreetmap/openstreetmap-website/pull/5518'>https://github.com/openstreetmap/openstreetmap-website/pull/5518</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5518/commits/df1a9bb2c9403a9d6d6cf76c73971b91145acff0" class="commit-link">df1a9bb</a> Simplify diary_comments_path calls in tests</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5518/commits/899795a82b584d802ea67f8cb01fc0130bf92804" class="commit-link">899795a</a> Rename diary_comments_path to user_diary_comments_path</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5518/commits/6f71b372fb1289e3733f9dbd929fd18efe850b13" class="commit-link">6f71b37</a> Change user's diary comments path to match model name</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5518/commits/08292292f09723806e4ca61b93106020e9c5a354" class="commit-link">0829229</a> Create diary_comments resources for users</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5518/commits/470e7c5c11ad6b8f3ab016c4480d707a8639d1e5" class="commit-link">470e7c5</a> Add tabbed navigation to user's diary comments page</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5518/commits/9c38e7fbc024e5e5184a92f96e48b8be029a012d" class="commit-link">9c38e7f</a> Create user comments controller base class</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5518/commits/fa3404a362ba7235647734273e03bd5f28ee683b" class="commit-link">fa3404a</a> Create changeset_comments resources for users</li>
</ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5518/files">16 files</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5518/files#diff-3c862c4b76c5629c1aeb9076a68805579f475b14d126b8a9691ff9ae2e00f76e">app/controllers/diary_comments_controller.rb</a>
(21)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5518/files#diff-a6e25ef8f99fd54f4ac2adaa587d80aa5e28444e0b387dd5ebc20913c2bcfb47">app/controllers/users/changeset_comments_controller.rb</a>
(14)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5518/files#diff-4e0cfb98d8a5fdff6c40e69bb63a6caed2e11f264a869f261710304f963b1729">app/controllers/users/comments_controller.rb</a>
(18)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5518/files#diff-b77b9f390f3a2d63e7a32640a118b82110574a7d60fa6760c9acea231f6ef479">app/controllers/users/diary_comments_controller.rb</a>
(16)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5518/files#diff-728b66d9a5cff7625a609dad624d6dc712557207a1790eddf1692ef92b1fd01c">app/models/changeset_comment.rb</a>
(2)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5518/files#diff-de4baa0059835d235e0c4a020d64dcf2a57fada71956bf893f33ccba49b62c26">app/views/diary_comments/index.html.erb</a>
(10)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5518/files#diff-71934712277bc845be20be90a2f23ff790ce21aad76f31eee6b28b21e4d07077">app/views/users/changeset_comments/_page.html.erb</a>
(22)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5518/files#diff-da5755ea95757f6f2b57a6b613203e037e00159ee18aededc44690157f2c641d">app/views/users/comments/index.html.erb</a>
(19)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5518/files#diff-b015e71361e7cb955da6ea8e0a666c97e7ed6821d31cd5f43a76321dba7c7280">app/views/users/diary_comments/_page.html.erb</a>
(0)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5518/files#diff-78ff736409d758722403cce31873ba803b3fb526d37398ca21caa557b54dfd95">app/views/users/show.html.erb</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5518/files#diff-44438ce218f5287c58d0017f965d888715635d94280669896f75841fbd7b4cd7">config/locales/en.yml</a>
(32)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5518/files#diff-959bc9abc46a55332bb64d5155a79323afa75a50ec1a2137ddd22d926f62c6c5">config/routes.rb</a>
(5)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5518/files#diff-2c3b3662e44be71c024967a2cefccfd23f10c363eadb2985ff4896454b01845e">test/controllers/diary_comments_controller_test.rb</a>
(51)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5518/files#diff-81528b41ece7b7a36b581293385dcdf26170382a6c851e683a8016504a91202d">test/controllers/users/changeset_comments_controller_test.rb</a>
(37)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5518/files#diff-978fd74096df1b2919e80aeccbccd6f93f4568175ba013fcb42538cb82fc8b34">test/controllers/users/diary_comments_controller_test.rb</a>
(70)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5518/files#diff-2719d3c650da3c587f727ca3c105e6bc93a7113f85717bb15983543cf4f85ae5">test/controllers/users_controller_test.rb</a>
(10)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/5518.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/5518.patch</a></li>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/5518.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/5518.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5518">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJGF6UFPF6EBI4SM532LL4JZAVCNFSM6AAAAABVOE3SIWVHI2DSMVQWIX3LMV43ASLTON2WKOZSG44TOMZSHE3TENQ">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLJYJAW5C23M35X4ZSL2LL4JZA5CNFSM6AAAAABVOE3SIWWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHKNO65HY.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5518</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5518",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5518",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>