<p></p>
<p dir="auto">The issue here is in osm.js.erb: if mlon and mlat are set, we're not initializing "loc" from the _osm_location cookie. Later on we cannot set mapParams.layers, since "loc" should be nil at this time. This impacts both the notes layer, as well as the map layer.</p>
<div class="highlight highlight-source-js" dir="auto"><pre class="notranslate"> <span class="pl-kos">}</span> <span class="pl-k">else</span> <span class="pl-k">if</span> <span class="pl-kos">(</span><span class="pl-s1">params</span><span class="pl-kos">.</span><span class="pl-c1">mlon</span> <span class="pl-c1">&&</span> <span class="pl-s1">params</span><span class="pl-kos">.</span><span class="pl-c1">mlat</span><span class="pl-kos">)</span> <span class="pl-kos">{</span>
<span class="pl-s1">mapParams</span><span class="pl-kos">.</span><span class="pl-c1">lon</span> <span class="pl-c1">=</span> <span class="pl-en">parseFloat</span><span class="pl-kos">(</span><span class="pl-s1">params</span><span class="pl-kos">.</span><span class="pl-c1">mlon</span><span class="pl-kos">)</span><span class="pl-kos">;</span>
<span class="pl-s1">mapParams</span><span class="pl-kos">.</span><span class="pl-c1">lat</span> <span class="pl-c1">=</span> <span class="pl-en">parseFloat</span><span class="pl-kos">(</span><span class="pl-s1">params</span><span class="pl-kos">.</span><span class="pl-c1">mlat</span><span class="pl-kos">)</span><span class="pl-kos">;</span>
<span class="pl-s1">mapParams</span><span class="pl-kos">.</span><span class="pl-c1">zoom</span> <span class="pl-c1">=</span> <span class="pl-en">parseInt</span><span class="pl-kos">(</span><span class="pl-s1">params</span><span class="pl-kos">.</span><span class="pl-c1">zoom</span> <span class="pl-c1">||</span> <span class="pl-c1">12</span><span class="pl-kos">)</span><span class="pl-kos">;</span>
<span class="pl-kos">}</span> <span class="pl-k">else</span> <span class="pl-k">if</span> <span class="pl-kos">(</span><span class="pl-s1">loc</span> <span class="pl-c1">=</span> <span class="pl-v">Cookies</span><span class="pl-kos">.</span><span class="pl-en">get</span><span class="pl-kos">(</span><span class="pl-s">'_osm_location'</span><span class="pl-kos">)</span><span class="pl-kos">)</span> <span class="pl-kos">{</span>
<span class="pl-s1">loc</span> <span class="pl-c1">=</span> <span class="pl-s1">loc</span><span class="pl-kos">.</span><span class="pl-en">split</span><span class="pl-kos">(</span><span class="pl-s">"|"</span><span class="pl-kos">)</span><span class="pl-kos">;</span>
<span class="pl-s1">mapParams</span><span class="pl-kos">.</span><span class="pl-c1">lon</span> <span class="pl-c1">=</span> <span class="pl-en">parseFloat</span><span class="pl-kos">(</span><span class="pl-s1">loc</span><span class="pl-kos">[</span><span class="pl-c1">0</span><span class="pl-kos">]</span><span class="pl-kos">)</span><span class="pl-kos">;</span>
<span class="pl-s1">mapParams</span><span class="pl-kos">.</span><span class="pl-c1">lat</span> <span class="pl-c1">=</span> <span class="pl-en">parseFloat</span><span class="pl-kos">(</span><span class="pl-s1">loc</span><span class="pl-kos">[</span><span class="pl-c1">1</span><span class="pl-kos">]</span><span class="pl-kos">)</span><span class="pl-kos">;</span>
<span class="pl-s1">mapParams</span><span class="pl-kos">.</span><span class="pl-c1">zoom</span> <span class="pl-c1">=</span> <span class="pl-en">parseInt</span><span class="pl-kos">(</span><span class="pl-s1">loc</span><span class="pl-kos">[</span><span class="pl-c1">2</span><span class="pl-kos">]</span><span class="pl-kos">)</span><span class="pl-kos">;</span><span class="pl-kos"></span></pre></div>
<div class="highlight highlight-source-js" dir="auto"><pre class="notranslate"> <span class="pl-s1">mapParams</span><span class="pl-kos">.</span><span class="pl-c1">layers</span> <span class="pl-c1">=</span> <span class="pl-s1">hash</span><span class="pl-kos">.</span><span class="pl-c1">layers</span> <span class="pl-c1">||</span> <span class="pl-kos">(</span><span class="pl-s1">loc</span> <span class="pl-c1">&&</span> <span class="pl-s1">loc</span><span class="pl-kos">[</span><span class="pl-c1">3</span><span class="pl-kos">]</span><span class="pl-kos">)</span> <span class="pl-c1">||</span> <span class="pl-s">''</span><span class="pl-kos">;</span></pre></div>
<p dir="auto">//CC: fyi <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/AntonKhorev/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/AntonKhorev">@AntonKhorev</a></p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/issues/3971#issuecomment-2601021733">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLI5UVUQECOZM3ASNYD2LQHV7AVCNFSM6AAAAABVPCCSSOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBRGAZDCNZTGM">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLO4WUNCSKYHESXFK4T2LQHV7A5CNFSM6AAAAABVPCCSSOWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTU3BBYSK.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/issues/3971/2601021733</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/issues/3971#issuecomment-2601021733",
"url": "https://github.com/openstreetmap/openstreetmap-website/issues/3971#issuecomment-2601021733",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>