<p></p>
<p><b>@gravitystorm</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5522#discussion_r1925653226">app/assets/javascripts/embed.js.erb</a>:</p>
<pre style='color:#555'>> @@ -15,10 +15,9 @@ window.onload = function () {
var query = (window.location.search || '?').slice(1),
args = {};
- var pairs = query.split('&');
- for (var i = 0; i < pairs.length; i++) {
- var parts = pairs[i].split('=');
- args[parts[0]] = decodeURIComponent(parts[1] || '');
+ for (var pair of query.split('&')) {
+ var [key, val] = pair.split('=');
+ args[key] = decodeURIComponent(val || '');
}
</pre>
<p dir="auto">I'm curious - is this refactoring done by an automatic tool (e.g. your IDE) or manually? I mean I like the result, but I'm not sure if it's related to the rest of the PR.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5522#discussion_r1925655984">app/assets/javascripts/embed.js.erb</a>:</p>
<pre style='color:#555'>> @@ -37,17 +36,17 @@ window.onload = function () {
map.attributionControl.setPrefix('');
map.removeControl(map.attributionControl);
- if (args.layer === "cyclosm") {
- new L.OSM.CyclOSM().addTo(map);
- } else if (args.layer === "cyclemap" || args.layer === "cycle map") {
- new L.OSM.CycleMap(thunderforestOptions).addTo(map);
- } else if (args.layer === "transportmap") {
- new L.OSM.TransportMap(thunderforestOptions).addTo(map);
- } else if (args.layer === "hot") {
- new L.OSM.HOT().addTo(map);
- } else {
- new L.OSM.Mapnik(mapnikOptions).addTo(map);
- }
+ var isDarkTheme = args.theme === "dark" || args.theme !== "light" && window.matchMedia("(prefers-color-scheme: dark)").matches;
</pre>
<p dir="auto">If eslint is happy, then I'd prefer to see some <code class="notranslate">()</code> to clarrify whether this is <code class="notranslate">(a || b) && c</code> or <code class="notranslate">a || (b && c)</code>, just for those of us who can't remember the precedence order 😄</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5522#pullrequestreview-2567765072">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLOGWN7OSAAPLFBOOS32L7EFHAVCNFSM6AAAAABVO6T25KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKNRXG43DKMBXGI">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLISPF5DOCXRZHETJA32L7EFHA5CNFSM6AAAAABVO6T25KWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUZBT6FA.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5522/review/2567765072</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5522#pullrequestreview-2567765072",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5522#pullrequestreview-2567765072",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>