<p></p>
<p><b>@hlfan</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5522#discussion_r1925875200">app/assets/javascripts/embed.js.erb</a>:</p>
<pre style='color:#555'>> @@ -15,10 +15,9 @@ window.onload = function () {
   var query = (window.location.search || '?').slice(1),
       args  = {};
 
-  var pairs = query.split('&');
-  for (var i = 0; i < pairs.length; i++) {
-    var parts = pairs[i].split('=');
-    args[parts[0]] = decodeURIComponent(parts[1] || '');
+  for (var pair of query.split('&')) {
+    var [key, val] = pair.split('=');
+    args[key] = decodeURIComponent(val || '');
   }
</pre>
<p dir="auto"><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/HolgerJeromin/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/HolgerJeromin">@HolgerJeromin</a> there's even a</p>
<div class="highlight highlight-source-js" dir="auto"><pre class="notranslate"><span class="pl-s1">urlArgs</span><span class="pl-kos">.</span><span class="pl-en">has</span><span class="pl-kos">(</span><span class="pl-s">'theme'</span><span class="pl-kos">,</span> <span class="pl-s">'dark'</span><span class="pl-kos">)</span></pre></div>
<p dir="auto">that we <a href="//caniuse.com/mdn-api_urlsearchparams_has_value_parameter" rel="nofollow">can't yet use</a> since it's only around since mid 2023.<br>
I cast it back to an object meanwhile.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5522#discussion_r1925875200">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLNU64HJRCCQ44N6UH32L7YR3AVCNFSM6AAAAABVO6T25KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKNRYGEZDQNZVGY">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLPYNCRNYZ7SF3OAXFD2L7YR3A5CNFSM6AAAAABVO6T25KWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUZCKEPI.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5522/review/2568128756</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5522#discussion_r1925875200",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5522#discussion_r1925875200",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>