<p></p>
<p><b>@hlfan</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5522#discussion_r1925789038">app/assets/javascripts/embed.js.erb</a>:</p>
<pre style='color:#555'>> @@ -15,10 +15,9 @@ window.onload = function () {
   var query = (window.location.search || '?').slice(1),
       args  = {};
 
-  var pairs = query.split('&');
-  for (var i = 0; i < pairs.length; i++) {
-    var parts = pairs[i].split('=');
-    args[parts[0]] = decodeURIComponent(parts[1] || '');
+  for (var pair of query.split('&')) {
+    var [key, val] = pair.split('=');
+    args[key] = decodeURIComponent(val || '');
   }
</pre>
<p dir="auto">Like all of this PR mainly manually, with <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2750674413" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/5421" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/5421/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/5421">#5421</a> in the back of my mind and the logic not having changed since 2015 I thought I'd see what I can do.<br>
To be fair, this is a refactor PR apart from the last two-line commit. But also the dark mode toggling caused rewriting the else-if-chain.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5522#discussion_r1925789038">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLKH4OCCF76F7BCDHP32L7P4TAVCNFSM6AAAAABVO6T25KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKNRXHE4DONJYGM">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLP34I5OHFEJS4NCDPT2L7P4TA5CNFSM6AAAAABVO6T25KWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUZCBQX6.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5522/review/2567987583</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5522#discussion_r1925789038",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5522#discussion_r1925789038",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>