<p></p>
<p><b>@HolgerJeromin</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5522#discussion_r1925790520">app/assets/javascripts/embed.js.erb</a>:</p>
<pre style='color:#555'>> @@ -37,17 +36,17 @@ window.onload = function () {
map.attributionControl.setPrefix('');
map.removeControl(map.attributionControl);
- if (args.layer === "cyclosm") {
- new L.OSM.CyclOSM().addTo(map);
- } else if (args.layer === "cyclemap" || args.layer === "cycle map") {
- new L.OSM.CycleMap(thunderforestOptions).addTo(map);
- } else if (args.layer === "transportmap") {
- new L.OSM.TransportMap(thunderforestOptions).addTo(map);
- } else if (args.layer === "hot") {
- new L.OSM.HOT().addTo(map);
- } else {
- new L.OSM.Mapnik(mapnikOptions).addTo(map);
- }
+ var isDarkTheme = args.theme === "dark" || args.theme !== "light" && window.matchMedia("(prefers-color-scheme: dark)").matches;
</pre>
<p dir="auto">Yes. Much easier.<br>
The code formatter <a href="https://prettier.io/playground/" rel="nofollow">prettier</a> returns this (with some line breaks):</p>
<div class="highlight highlight-source-js" dir="auto"><pre class="notranslate"><span class="pl-k">var</span> <span class="pl-s1">isDarkTheme</span> <span class="pl-c1">=</span> <span class="pl-s1">args</span><span class="pl-kos">.</span><span class="pl-c1">theme</span> <span class="pl-c1">===</span> <span class="pl-s">"dark"</span> <span class="pl-c1">||</span> <span class="pl-kos">(</span><span class="pl-s1">args</span><span class="pl-kos">.</span><span class="pl-c1">theme</span> <span class="pl-c1">!==</span> <span class="pl-s">"light"</span> <span class="pl-c1">&&</span> <span class="pl-smi">window</span><span class="pl-kos">.</span><span class="pl-en">matchMedia</span><span class="pl-kos">(</span><span class="pl-s">"(prefers-color-scheme: dark)"</span><span class="pl-kos">)</span><span class="pl-kos">.</span><span class="pl-c1">matches</span><span class="pl-kos">)</span><span class="pl-kos">;</span></pre></div>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5522#discussion_r1925790520">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLPRQ35DTSMVX6DIZDD2L7QBJAVCNFSM6AAAAABVO6T25KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKNRXHE4TAMBRGQ">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLLY4F3WHC2K7E5PDTD2L7QBJA5CNFSM6AAAAABVO6T25KWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUZCBVP4.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5522/review/2567990014</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5522#discussion_r1925790520",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5522#discussion_r1925790520",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>