<p></p>
<p><b>@AntonKhorev</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5536#discussion_r1927991449">app/abilities/ability.rb</a>:</p>
<pre style='color:#555'>> @@ -43,7 +43,7 @@ def initialize(user)
can :update, DiaryEntry, :user => user
can [:create], DiaryComment
can [:show, :create, :destroy], Follow
- can [:read, :create, :mark, :unmute, :destroy], Message
+ can :manage, Message
</pre>
<p dir="auto">And it didn't because <code class="notranslate">:manage</code> grants all abilities.</p>
<p dir="auto">Rewrote it to not use <code class="notranslate">:manage</code>. Marks and mutes now authorize messages as parent resources, which means they check <code class="notranslate">:show</code> (included in <code class="notranslate">:read</code>) on messages.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5536#discussion_r1927991449">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJ72LAWIPZZHATSOHL2MGOUPAVCNFSM6AAAAABVWG24VCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKNZRGUYDANRYGI">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLNISOZGHBMOPKXIEAT2MGOUPA5CNFSM6AAAAABVWG24VCWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUZIX6IU.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5536/review/2571500682</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5536#discussion_r1927991449",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5536#discussion_r1927991449",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>