<p></p>
<p><b>@hlfan</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5550#discussion_r1930295112">app/assets/javascripts/embed.js.erb</a>:</p>
<pre style='color:#555'>> +  var baseLayers = {
+    cyclosm: ["CyclOSM"],
+    cyclemap: ["CycleMap", thunderforestOptions],
+    transportmap: ["TransportMap", thunderforestOptions],
+    hot: ["HOT"],
+    mapnik: ["Mapnik", mapnikOptions]
+  };
+  baseLayers["cycle map"] = baseLayers.cyclemap;
+  var [layer, options] = baseLayers[args.layer] || baseLayers.mapnik;
+  new L.OSM[layer](options || {}).addTo(map);
</pre>
<p dir="auto">I also think big potential here was hidden in the else-if chain. I definitely can see the next version here be <a href="//github.com/openstreetmap/openstreetmap-website/blob/master/config/layers.yml">layers.yml</a>-based, but it should be filtered to what's necessary and include toggling to <code class="notranslate">leafletOsmDarkId</code>.<br>
And I haven't figured out how to do that compactly so this is more of a stop-gap that I can throw a ternary onto to add dark mode later.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5550#discussion_r1930295112">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLPC3R2AKIGMVHDMSOD2MYCTZAVCNFSM6AAAAABV2NKF6SVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKNZVGA2DOMRVGI">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLOOBASZYDB3LOSRTJL2MYCTZA5CNFSM6AAAAABV2NKF6SWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUZPQNFI.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5550/review/2575047252</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5550#discussion_r1930295112",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5550#discussion_r1930295112",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>