<p></p>
<p><b>@AntonKhorev</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5121#discussion_r1931977636">lib/rich_text.rb</a>:</p>
<pre style='color:#555'>> @@ -65,6 +65,32 @@ def description
 
     protected
 
+    def truncate_html(html_doc, max_length = nil, empty_tag_length = 1000)
+      return html_doc if max_length.nil?
+
+      doc = Nokogiri::HTML::DocumentFragment.parse(html_doc)
+      accumulated_length = 0
+      last_child = nil
+
+      doc.traverse do |node|
</pre>
<p dir="auto">My idea was that there are some types of elements that you either completely keep or completely discard. A paragraph would be one of them. Here instead a paragraph may get truncated after after any of elements inside it. Let's say you have a link, any if that link happens to go over the truncation threshold, the rest of the paragraph gets thrown out. That can make it unreadable.</p>
<p dir="auto">This is even more true for tables. Truncation as implemented here can stop in the middle of some cell. It won't try to complete a row, although completing a row wouldn't work in general. Tables probably also need to be either entirely in or entirely out. Something like <code class="notranslate"><div></code> or <code class="notranslate"><section></code>, that can be included partially.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5121#pullrequestreview-2577898800">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLPGHYCTO6NGXRGTWD32M5Q2XAVCNFSM6AAAAABNFQLUA6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKNZXHA4TQOBQGA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLOEXG4EZA7YDQWXGE32M5Q2XA5CNFSM6AAAAABNFQLUA6WGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUZU6OTA.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5121/review/2577898800</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5121#pullrequestreview-2577898800",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5121#pullrequestreview-2577898800",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>