<p></p>
<p><b>@nenad-vujicic</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5579#discussion_r1937480141">app/models/note.rb</a>:</p>
<pre style='color:#555'>> def description
- comments.first.body
+ if user_ip.nil? && user_id.nil?
+ comments.first.body
+ else
+ RichText.new("text", super)
+ end
end
</pre>
<blockquote>
<p dir="auto">How is this PR going to go in a different direction?</p>
</blockquote>
<p dir="auto">Well, honestly, I don't know .. We started with one idea (simple wrappers around <code class="notranslate">comments</code>) and converged to something different (<code class="notranslate">all_comments</code> + other stuffs) in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2795333096" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/5511" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/5511/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/5511">#5511</a>, so I thought there is perhaps another way. Plus, I'm not sure why <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2795333096" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/5511" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/5511/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/5511">#5511</a> is evolving so slow (I believe I messed up something, but not sure where). It's not a problem to wait some time (how much we need) to digest these changes and be sure they will work fine, but is that the case here (we already have some plan + it's ~50 lines of code)?</p>
<p dir="auto">If you are sure <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2795333096" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/5511" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/5511/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/5511">#5511</a> is proper direction, I'll be very happy to close this PR :-)</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5579#discussion_r1937480141">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLOB52F26VFS7IB2IID2NOIH5AVCNFSM6AAAAABWFEHHFSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKOBXGA3DGNZZGI">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLOEKUWZPK3YQEN6EGL2NOIH5A5CNFSM6AAAAABWFEHHFSWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTU2GN27A.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5579/review/2587063792</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5579#discussion_r1937480141",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5579#discussion_r1937480141",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>