<p></p>
<p><b>@AntonKhorev</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5402#discussion_r1937282323">app/assets/javascripts/heatmap.js</a>:</p>
<pre style='color:#555'>> + type: "threshold",
+ range: currentTheme === "dark" ? rangeColors : Array.from(rangeColors).reverse(),
+ domain: [10, 20, 30, 40]
+ }
+ }
+ }, [
+ [Tooltip, {
+ text: (date, value) => getTooltipText(date, value, locale)
+ }]
+ ]);
+ }
+});
+
+function getThemeFromColorScheme(colorScheme) {
+ if (colorScheme === "auto") {
+ return window.matchMedia("(prefers-color-scheme: dark)").matches ? "dark" : "light";
</pre>
<p dir="auto">You already have <code class="notranslate">mediaQuery</code> defined. It can be used here:</p>
⬇️ Suggested change
<pre style="color: #555">- return window.matchMedia("(prefers-color-scheme: dark)").matches ? "dark" : "light";
+ return mediaQuery.matches ? "dark" : "light";
</pre>
<p dir="auto">For this to work, declarations have to be moved around. Maybe this function doesn't need to be declared. You already have <code class="notranslate">if (colorScheme === "auto") ...</code> above that is not inside a function.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5402#pullrequestreview-2586681226">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLPVENGTXTJWHD6QENL2NNYOPAVCNFSM6AAAAABTWNRZO6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKOBWGY4DCMRSGY">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLI365Y43TL232UXDE32NNYOPA5CNFSM6AAAAABTWNRZO6WGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTU2FWPYU.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5402/review/2586681226</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5402#pullrequestreview-2586681226",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5402#pullrequestreview-2586681226",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>