<p></p>
<p><b>@nertc</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5121#discussion_r1937179354">lib/rich_text.rb</a>:</p>
<pre style='color:#555'>> + def truncate_html(html_doc, max_length = nil, empty_tag_length = 1000)
+ return html_doc if max_length.nil?
+
+ doc = Nokogiri::HTML::DocumentFragment.parse(html_doc)
+ accumulated_length = 0
+ last_child = nil
+
+ doc.traverse do |node|
+ if accumulated_length >= max_length
+ node.remove unless !last_child.nil? && last_child.ancestors.include?(node)
+ next
+ end
+
+ next unless node.children.empty?
+
+ accumulated_length += node.text? ? node.text.length : empty_tag_length
</pre>
<p dir="auto">Maybe changing checking if the tag is empty to checking if the tag is <code class="notranslate"><img></code> will be better. Therefore, tags like <code class="notranslate"><br></code> or <code class="notranslate"><p></p></code> will take 1 symbol space, while <code class="notranslate"><img></code> will take for example 1000 symbol space. If we want any other tags to be treated in a specific way, feel free to suggest.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5121#discussion_r1937179354">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLN3OKKJELECK6LTRL32NNUWZAVCNFSM6AAAAABNFQLUA6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKOBWGQ4TEOBSGU">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLLOOOJXOGJGIJONKBD2NNUWZA5CNFSM6AAAAABNFQLUA6WGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTU2FK7ZS.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5121/review/2586492825</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5121#discussion_r1937179354",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5121#discussion_r1937179354",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>