<p dir="auto"><span class="issue-keyword tooltipped tooltipped-se" aria-label="This pull request closes issue #5587.">Fixes</span> <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2825334639" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/5587" data-hovercard-type="issue" data-hovercard-url="/openstreetmap/openstreetmap-website/issues/5587/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/issues/5587">#5587</a>.</p>
<p dir="auto">I think it's safer to always use <code class="notranslate">URI.encode_uri_component</code> instead of <code class="notranslate">URI.encode_www_form_component</code>. Space is going to be encoded as <code class="notranslate">%20</code>. Space as <code class="notranslate">+</code> sometimes doesn't work.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/openstreetmap/openstreetmap-website/pull/5588'>https://github.com/openstreetmap/openstreetmap-website/pull/5588</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5588/commits/a0e78a5caf6bd337851073fc03847e4839be8a40" class="commit-link">a0e78a5</a> Use URI.encode_uri_component when generating share urls</li>
</ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5588/files">2 files</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5588/files#diff-22f6dbff3e22400e636b6f70bcaef16d9b6038aad4ac96daa11350633272bfc6">app/helpers/social_share_button_helper.rb</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5588/files#diff-5aab28ad7860eb0242ea2309b822517bcb26c1ddbbb9686945b14d1fb8791f74">test/helpers/social_share_button_helper_test.rb</a>
(7)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/5588.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/5588.patch</a></li>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/5588.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/5588.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5588">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLMT6BBVVR3LCVDFVEL2NUF2TAVCNFSM6AAAAABWJQYVMSVHI2DSMVQWIX3LMV43ASLTON2WKOZSHAZDKMZVGM3TINI">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLMTQIT5F5IFFEW53TL2NUF2TA5CNFSM6AAAAABWJQYVMSWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHKQZ32CE.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5588</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5588",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5588",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>