<p></p>
<p><b>@hlfan</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5597#discussion_r1940541052">app/assets/javascripts/edit/id.js.erb</a>:</p>
<pre style='color:#555'>>  
-    if (id.data("gpx")) {
-      params.set("gpx", id.data("gpx"));
-    } else if (hashParams.gpx) {
-      params.set("gpx", hashParams.gpx);
-    }
+  params.set("map", [
+    (mapParams.object && hashArgs.center && hashArgs.zoom) || (id.data("lat") && id.data("lon") && 16) || mapParams.zoom || 17,
+    (mapParams.object && hashArgs.center?.lat) || (id.data("lon") && id.data("lat")) || mapParams.lat,
+    (mapParams.object && hashArgs.center?.lng) || (id.data("lat") && id.data("lon")) || mapParams.lon
+  ].join("/"));
</pre>
<p dir="auto">It decouples the parameters' conditions, opening them up to simplification.</p>
<div class="highlight highlight-source-js" dir="auto"><pre class="notranslate"><span class="pl-kos">[</span>
  <span class="pl-s1">mapParams</span><span class="pl-kos">.</span><span class="pl-c1">zoom</span> <span class="pl-c1">||</span> <span class="pl-c1">17</span><span class="pl-kos">,</span>  <span class="pl-c">// dropping hashArgs, this is already used in mapParams if it exists,</span>
                         <span class="pl-c">// and the secondary default value of 16</span>
  <span class="pl-s1">hashArgs</span><span class="pl-kos">.</span><span class="pl-c1">center</span><span class="pl-kos">?.</span><span class="pl-c1">lat</span> <span class="pl-c1">||</span> <span class="pl-s1">id</span><span class="pl-kos">.</span><span class="pl-en">data</span><span class="pl-kos">(</span><span class="pl-s">"lat"</span><span class="pl-kos">)</span> <span class="pl-c1">||</span> <span class="pl-s1">mapParams</span><span class="pl-kos">.</span><span class="pl-c1">lat</span><span class="pl-kos">,</span>
  <span class="pl-s1">hashArgs</span><span class="pl-kos">.</span><span class="pl-c1">center</span><span class="pl-kos">?.</span><span class="pl-c1">lng</span> <span class="pl-c1">||</span> <span class="pl-s1">id</span><span class="pl-kos">.</span><span class="pl-en">data</span><span class="pl-kos">(</span><span class="pl-s">"lon"</span><span class="pl-kos">)</span> <span class="pl-c1">||</span> <span class="pl-s1">mapParams</span><span class="pl-kos">.</span><span class="pl-c1">lon</span>
<span class="pl-kos">]</span></pre></div>
<p dir="auto">And I'd argue this is less hard to reason about than a version written with <code class="notranslate">if</code>-<code class="notranslate">else if</code>.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5597#discussion_r1940541052">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLP5YQHF44ECWUEL5YL2OBIEPAVCNFSM6AAAAABWMGSMVOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKOJRG44TKMJVGM">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLJEGRGLI2ZLCEOSKOD2OBIEPA5CNFSM6AAAAABWMGSMVOWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTU2POT5C.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5597/review/2591795153</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5597#discussion_r1940541052",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5597#discussion_r1940541052",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>