<p></p>
<p><b>@AntonKhorev</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5579#discussion_r1940217600">app/helpers/note_helper.rb</a>:</p>
<pre style='color:#555'>> +  def note_description(author, description, user_id, user_ip)
+    if !(user_id.nil? && user_ip.nil?) && !author.nil? && author.status == "deleted"
+      RichText.new("text", t("notes.show.description_when_author_is_deleted"))
+    else
+      description
+    end
+  end
</pre>
<p dir="auto">By <em>Why wouldn't you start with a helper?</em> I meant <em>Why wouldn't you make it the first commit of the PR</em>.</p>
<p dir="auto">As long as you're taking <code class="notranslate">description</code> from exactly the same place as <code class="notranslate">author</code>, you only need to check if <code class="notranslate">author</code> is deleted. You don't need to check <code class="notranslate">user_id</code> and <code class="notranslate">user_ip</code>. You already have a commit doing exactly that in another PR: <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/openstreetmap/openstreetmap-website/commit/9e70276e1997d22e7e4cf496b87157749bb9e468/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/commit/9e70276e1997d22e7e4cf496b87157749bb9e468"><tt>9e70276</tt></a>.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5579#pullrequestreview-2591288754">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLPYT3ARGTQI2APOKFL2N7VJVAVCNFSM6AAAAABWFEHHFSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKOJRGI4DQNZVGQ">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLPQ2DGNR3HVH2T5RET2N7VJVA5CNFSM6AAAAABWFEHHFSWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTU2OPW3E.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5579/review/2591288754</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5579#pullrequestreview-2591288754",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5579#pullrequestreview-2591288754",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>