<p></p>
<p><b>@AntonKhorev</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5402#discussion_r1941615105">test/controllers/users_controller_test.rb</a>:</p>
<pre style='color:#555'>> + # Test user with no changesets
+ user_without_changesets = create(:user)
+ get user_path(user_without_changesets)
+ assert_response :success
+ assert_select "div#cal-heatmap", 1
</pre>
<p dir="auto">This fails because <code class="notranslate">@heatmap_data.present?</code> is false when <code class="notranslate">@heatmap_data</code> is an empty array.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5402#pullrequestreview-2593593996">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJUNEYXA5J7JDUSKX32OD3THAVCNFSM6AAAAABTWNRZO6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKOJTGU4TGOJZGY">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLP3FWUUSF3SCVV6HSL2OD3THA5CNFSM6AAAAABTWNRZO6WGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTU2S4NIY.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5402/review/2593593996</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5402#pullrequestreview-2593593996",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5402#pullrequestreview-2593593996",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>