<p></p>
<p dir="auto">Merged, thanks.</p>
<p dir="auto">Next we probably want to fix the bug where a note of deleted user has no comments because they are filtered out, but the code tries to access the first comment:</p>
<ul dir="auto">
<li>changing <code class="notranslate">comments</code> to <code class="notranslate">all_comments</code> in <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/openstreetmap/openstreetmap-website/commit/690d392bd866a411bed93aded9b18f884bcfcc21/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/commit/690d392bd866a411bed93aded9b18f884bcfcc21"><tt>690d392</tt></a></li>
<li>dropping either 0 or 1 comment in <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/openstreetmap/openstreetmap-website/commit/0e60e2e71579dff7b7b163f08bafd278deb9caae/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/commit/0e60e2e71579dff7b7b163f08bafd278deb9caae"><tt>0e60e2e</tt></a>, although you probably don't need to define the <code class="notranslate">author_deleted?</code> predicate</li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5579#issuecomment-2634185487">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLI2M77H6QGJFEO42JL2ODGT5AVCNFSM6AAAAABWFEHHFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMZUGE4DKNBYG4">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLO6RSNGNLJYFEAGOF32ODGT5A5CNFSM6AAAAABWFEHHFSWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTU5AJ5Q6.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5579/c2634185487</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5579#issuecomment-2634185487",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5579#issuecomment-2634185487",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>