<p dir="auto">Untangling <code class="notranslate">FOSSGISOSRMEngine</code> and moving from <code class="notranslate">push</code>ing <code class="notranslate">for</code> loops to <code class="notranslate">.map()</code> for the other engines.</p>
<h3 dir="auto">Description</h3>
<p dir="auto">The three routing engines' code now follows a similar structure:</p>
<div class="highlight highlight-source-js" dir="auto"><pre class="notranslate"><span class="pl-k">const</span> ...<span class="pl-v">Engine</span> <span class="pl-c1">=</span> <span class="pl-k">function</span> <span class="pl-kos">(</span><span class="pl-s1">id</span><span class="pl-kos">,</span> ...<span class="pl-kos">)</span> <span class="pl-kos">{</span>
  <span class="pl-k">function</span> <span class="pl-s1">_processDirections</span><span class="pl-kos">(</span>...<span class="pl-kos">)</span> <span class="pl-kos">{</span>...<span class="pl-kos">}</span>

  <span class="pl-k">return</span> <span class="pl-kos">{</span>
    ...<span class="pl-kos">,</span>
    <span class="pl-en">getRoute</span>: <span class="pl-k">function</span> <span class="pl-kos">(</span><span class="pl-s1">points</span><span class="pl-kos">,</span> <span class="pl-s1">callback</span><span class="pl-kos">)</span> <span class="pl-kos">{</span>
      <span class="pl-s1">data</span> <span class="pl-c1">=</span> <span class="pl-kos">{</span>...<span class="pl-kos">}</span><span class="pl-kos">;</span>
      <span class="pl-k">return</span> <span class="pl-s1">$</span><span class="pl-kos">.</span><span class="pl-en">ajax</span><span class="pl-kos">(</span><span class="pl-kos">{</span>
        ...<span class="pl-kos">,</span>
        <span class="pl-c1">success</span>: <span class="pl-k">function</span> <span class="pl-c">// that calls the callback with _processDirections</span>
      <span class="pl-kos">}</span><span class="pl-kos">)</span><span class="pl-kos">;</span>
    <span class="pl-kos">}</span>
  <span class="pl-kos">}</span><span class="pl-kos">;</span>
<span class="pl-kos">}</span><span class="pl-kos">;</span><span class="pl-kos"></span></pre></div>
<h3 dir="auto">How has this been tested?</h3>
<p dir="auto">Creating a conditional dev tools breakpoint and shoving it all in there.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/openstreetmap/openstreetmap-website/pull/5621'>https://github.com/openstreetmap/openstreetmap-website/pull/5621</a></p>

<h4>Commit Summary</h4>
<ul>
  <li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5621/commits/0f20bf9ffb02cd92507b541e4bd34c8bf1ff694f" class="commit-link">0f20bf9</a>  Refactor direction engines and unify structure</li>
</ul>

<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5621/files">3 files</a>)</p>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5621/files#diff-7e2536f2e9b6f209b368993e27a7ecbb60869fc394321af9c2d735c8c02e8fa9">app/assets/javascripts/index/directions/fossgis_osrm.js</a>
    (265)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5621/files#diff-a9cecd581b2c9e4e43ee8e0b73ee178a13779019da8bcb9c13d209843c716711">app/assets/javascripts/index/directions/fossgis_valhalla.js</a>
    (189)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5621/files#diff-ef6651e3e37e12a6ee24e6c9efaa98ddd129a20a5631401cea6e0642fcfffb7a">app/assets/javascripts/index/directions/graphhopper.js</a>
    (124)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/5621.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/5621.patch</a></li>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/5621.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/5621.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5621">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLLPXL2H4CXGZ64YAGD2OJKR7AVCNFSM6AAAAABWRXZYIWVHI2DSMVQWIX3LMV43ASLTON2WKOZSHAZTGNRXHE3TMMY">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLKANCPBVV4VYR7MHHT2OJKR7A5CNFSM6AAAAABWRXZYIWWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHKRZUFSM.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5621</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5621",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5621",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>