<h3 dir="auto">Description</h3>
<p dir="auto">PR fixes bug where a note of deleted user has no comments, but the code tries to access the first comment by switching to using <code class="notranslate">.all_comments</code> (instead of <code class="notranslate">.comments</code>) and removing dropping first comment (if author is deleted) when displaying notes comments in sidebar.</p>
<p dir="auto">Suggested <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5579#issuecomment-2634185487" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/5579/hovercard">here</a>.</p>
<h3 dir="auto">How has this been tested?</h3>
<p dir="auto">Automated tests, manual testing before and after migration.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/openstreetmap/openstreetmap-website/pull/5609'>https://github.com/openstreetmap/openstreetmap-website/pull/5609</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5609/commits/c66d0ac26be52fec0df7818d686d072479eb9215" class="commit-link">c66d0ac</a> Switches from comments to all_comments</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5609/commits/0c08a73ecf5939a83a36a7de18f6d32d5ee5fb03" class="commit-link">0c08a73</a> Removes dropping note's first comment</li>
</ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5609/files">2 files</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5609/files#diff-08ddccf408b18937e98b422e555eaf851c2a02c3ba815c5aeb8bc00efe65ecab">app/models/note.rb</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5609/files#diff-84d04c9c37a8be927ab1870e6b3c1940f670585b77b8e88c32d6ded35cf87dc7">app/views/notes/show.html.erb</a>
(4)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/5609.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/5609.patch</a></li>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/5609.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/5609.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5609">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJITVWZAYWWFOFFLYD2OHUIXAVCNFSM6AAAAABWQX7BVWVHI2DSMVQWIX3LMV43ASLTON2WKOZSHAZTENJYGI4TANA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLMOGEQICVVBQ6YAD4D2OHUIXA5CNFSM6AAAAABWQX7BVWWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHKRVOI7A.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5609</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5609",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5609",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>