<p></p>
<p><b>@HolgerJeromin</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5642#discussion_r1948535621">app/assets/javascripts/index/directions/fossgis_valhalla.js</a>:</p>
<pre style='color:#555'>> @@ -99,22 +99,18 @@
language: I18n.currentLocale()
}
})
- };
- return $.ajax({
- url: OSM.FOSSGIS_VALHALLA_URL,
- data,
- dataType: "json",
- success: function ({ trip }) {
- if (trip.status === 0) {
- callback(false, _processDirections(trip.legs));
- } else {
- callback(true);
+ });
+ return fetch(OSM.FOSSGIS_VALHALLA_URL + "?" + query)
+ .then(response => response.json())
+ .then(({ trip }) => {
+ if (trip.status !== 0) {
</pre>
<p dir="auto">The callback result can not be used.</p>
<div class="highlight highlight-source-ts" dir="auto"><pre class="notranslate"> <span class="pl-k">if</span> <span class="pl-kos">(</span><span class="pl-s1">trip</span><span class="pl-kos">.</span><span class="pl-c1">status</span> <span class="pl-c1">!==</span> <span class="pl-c1">0</span><span class="pl-kos">)</span> <span class="pl-kos">{</span>
<span class="pl-k">return</span> <span class="pl-en">callback</span><span class="pl-kos">(</span><span class="pl-c1">true</span><span class="pl-kos">)</span><span class="pl-kos">;</span>
<span class="pl-kos">}</span>
<span class="pl-k">return</span> <span class="pl-en">callback</span><span class="pl-kos">(</span><span class="pl-c1">false</span><span class="pl-kos">,</span> <span class="pl-en">_processDirections</span><span class="pl-kos">(</span><span class="pl-s1">trip</span><span class="pl-kos">.</span><span class="pl-c1">legs</span><span class="pl-kos">)</span><span class="pl-kos">)</span><span class="pl-kos">;</span></pre></div>
<p dir="auto">or</p>
<div class="highlight highlight-source-ts" dir="auto"><pre class="notranslate"> <span class="pl-k">if</span> <span class="pl-kos">(</span><span class="pl-s1">trip</span><span class="pl-kos">.</span><span class="pl-c1">status</span> <span class="pl-c1">!==</span> <span class="pl-c1">0</span><span class="pl-kos">)</span> <span class="pl-kos">{</span>
<span class="pl-en">callback</span><span class="pl-kos">(</span><span class="pl-c1">true</span><span class="pl-kos">)</span><span class="pl-kos">;</span>
<span class="pl-k">return</span><span class="pl-kos">;</span>
<span class="pl-kos">}</span>
<span class="pl-en">callback</span><span class="pl-kos">(</span><span class="pl-c1">false</span><span class="pl-kos">,</span> <span class="pl-en">_processDirections</span><span class="pl-kos">(</span><span class="pl-s1">trip</span><span class="pl-kos">.</span><span class="pl-c1">legs</span><span class="pl-kos">)</span><span class="pl-kos">)</span><span class="pl-kos">;</span></pre></div>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5642#pullrequestreview-2604912111">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLK5FIYFUHZFHFA6DXD2PBKTRAVCNFSM6AAAAABWZ2OIO6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMMBUHEYTEMJRGE">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLNFANLB77S77UVAVOL2PBKTRA5CNFSM6AAAAABWZ2OIO6WGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTU3IPG66.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5642/review/2604912111</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5642#pullrequestreview-2604912111",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5642#pullrequestreview-2604912111",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>