<p></p>
<p><b>@tomhughes</b> requested changes on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5622#discussion_r1951694506">db/migrate/20250206202905_add_text_index_to_notes.rb</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,11 @@
+class AddTextIndexToNotes < ActiveRecord::Migration[7.2]
+  disable_ddl_transaction!
+
+  def up
+    add_index :notes, "to_tsvector('english', description)", :using => "GIN", :name => "index_notes_on_description", :algorithm => :concurrently
+  end
+
+  def down
</pre>
<p dir="auto">There's no need for a separate <code class="notranslate">down</code> here - you get get rid of it and rename <code class="notranslate">up</code> as <code class="notranslate">change</code> and rails will figure out how to reverse things if necessary.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5622#pullrequestreview-2610211024">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLPDXXWW3QE2SEELY6D2PJ2LFAVCNFSM6AAAAABWTKGAGGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMMJQGIYTCMBSGQ">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLODE6JTGXRZRNOKY732PJ2LFA5CNFSM6AAAAABWTKGAGGWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTU3SSUNA.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5622/review/2610211024</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5622#pullrequestreview-2610211024",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5622#pullrequestreview-2610211024",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>