<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5642#discussion_r1951351389">app/assets/javascripts/index/directions/fossgis_osrm.js</a>:</p>
<pre style='color:#555'>>              if (response.code !== "Ok") {
-              return callback(true);
+              throw new TypeError("Response " + response.code);
</pre>
<p dir="auto">Was there a reason for using <code class="notranslate">TypeError</code> rather than a simple <code class="notranslate">Error</code> here? It doesn't really seem to fit the description of what a <code class="notranslate">TypeError</code> is?</p>
<p dir="auto">Also given that nothing uses the description what's the purpose of including it? Just for easier debugging?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5642#pullrequestreview-2609607925">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLN5IW6RZ663G3OUNIL2PI42TAVCNFSM6AAAAABWZ2OIO6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMMBZGYYDOOJSGU">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLPEQSQQLHXH7BBFHJ32PI42TA5CNFSM6AAAAABWZ2OIO6WGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTU3RN2PK.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5642/review/2609607925</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5642#pullrequestreview-2609607925",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5642#pullrequestreview-2609607925",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>