<p dir="auto">Using flash for this is silly, and has weird effects as observed in the fact that I had to fix a test which had accidentally relied on fetching user details from the API causing a session to spring into existence because it wrote to flash.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/openstreetmap/openstreetmap-website/pull/5658'>https://github.com/openstreetmap/openstreetmap-website/pull/5658</a></p>

<h4>Commit Summary</h4>
<ul>
  <li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5658/commits/43f40c5d036aaea80f5dae040c88f2a4cabdf8ff" class="commit-link">43f40c5</a>  Stop using session flash to communicate with callbacks</li>
</ul>

<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5658/files">7 files</a>)</p>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5658/files#diff-51243a95c08f37346b52b223c3e9ca80e954787aa019156279ff2e52ab9fc2ae">app/controllers/accounts/terms_controller.rb</a>
    (3)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5658/files#diff-52cb10dc1aabfdb745ff2c590fb82ce44f6f1078750119a2b1305505475f7909">app/controllers/api/users_controller.rb</a>
    (12)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5658/files#diff-380aab66173996fadff8576f19062da8bacc45be57582f15afb9fd46c411cbbf">app/controllers/api_controller.rb</a>
    (8)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5658/files#diff-766c34fd6533171eaf54300c153f89d6002c35c02cfc9c5b219251f85180ad07">app/controllers/application_controller.rb</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5658/files#diff-8ac25145a80d1093fb7a8f1098aa9d5b0a1d70ced7333342a9ec569227d0a82f">app/controllers/concerns/session_methods.rb</a>
    (9)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5658/files#diff-cdec550eeeb8fc63be2b5687170f594651a8d0b7f0465c9d807baef392639b6e">app/controllers/sessions_controller.rb</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5658/files#diff-a1eb8d1c90c9c5b030a23251f16373194677dff9ba313f63dd850d586ea15c85">test/integration/user_blocks_test.rb</a>
    (2)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/5658.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/5658.patch</a></li>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/5658.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/5658.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5658">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLLZHZZO4ITC45KB5FD2PKHLZAVCNFSM6AAAAABW6KJT6GVHI2DSMVQWIX3LMV43ASLTON2WKOZSHA2DMOBVHEZDQOA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLMR2UOBXXRBV5VSAAT2PKHLZA5CNFSM6AAAAABW6KJT6GWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHKTL5ADA.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5658</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5658",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5658",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>