<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5452#discussion_r1951682192">app/controllers/api/user_blocks/active_lists_controller.rb</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,23 @@
+module Api
+ module UserBlocks
+ class ActiveListsController < ApiController
+ before_action :disable_blocks_check
</pre>
<p dir="auto">Why use flash to smuggle the skip blocks flag to <code class="notranslate">setup_user_auth</code>? Could we not just pass an argument to the <code class="notranslate">authorize</code> callback and have that pass it on to <code class="notranslate">setup_user_auth</code>?</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5452#pullrequestreview-2610172848">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJ5HW2ZDCATUFUOTLD2PJY3ZAVCNFSM6AAAAABUOF7RNGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMMJQGE3TEOBUHA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLP7FZHEYAFL4XN5WAD2PJY3ZA5CNFSM6AAAAABUOF7RNGWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTU3SQJ3A.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5452/review/2610172848</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5452#pullrequestreview-2610172848",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5452#pullrequestreview-2610172848",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>