<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5669#discussion_r1955178113">app/assets/javascripts/index/layers/notes.js</a>:</p>
<pre style='color:#555'>>  
-      noteLoader = null;
+          for (var id in oldNotes) {
+            noteLayer.removeLayer(oldNotes[id]);
+          }
+        })
+        .catch(() => {})
</pre>
<p dir="auto">So this is what I wasn't sure about - what happens if a fetch is rejected and nothing catches the rejection.</p>
<p dir="auto">If that leads to a message in the console then we should probably have a no-op catch on all of them? Unless we want network errors to get reported in the console but in that case the ones that exist to catch aborts should rethrow other errors?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5669#discussion_r1955178113">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJY7PBENP4O6QOQJE32PT6XBAVCNFSM6AAAAABXCRWC76VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMMJWGE3DCNRUHA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLMZ5SO4B7HEFHFZJIL2PT6XBA5CNFSM6AAAAABXCRWC76WGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTU3552XA.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5669/review/2616161648</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5669#discussion_r1955178113",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5669#discussion_r1955178113",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>