<span style="color: transparent; display: none; height: 0; max-height: 0; max-width: 0; opacity: 0; overflow: hidden; mso-hide: all; visibility: hidden; width: 0;">
<p dir="auto">This is also a problem with the notes comment feed, which contains links with fragments (targetting the comment id).</p>
<p dir="auto"><code class="notranslate">curl https://www.openstreetmap.org/api/0.6/notes/feed?bbox=8.1706155,51.8144663,8.5269845,51.9737924</code></p>
<pre class="notranslate"><code class="notranslate"><?xml version="1.0" encoding="UTF-8"?>
<rss version="2.0" xmlns:dc=["http://purl.org/dc/elements/1.1/"](http://purl.org/dc/elements/1.1/)
xmlns:geo=["http://www.w3.org/2003/01/geo/wgs84_pos#"](http://www.w3.org/2003/01/geo/wgs84_pos#)
xmlns:georss=["http://www.georss.org/georss"](http://www.georss.org/georss)>
<channel>
<title>OpenStreetMap Notes</title>
<description>A list of notes, reported, commented on or closed in
your area [(51.8144663|8.1706155) --
(51.9737924|8.5269845)]</description>
<link>https://www.openstreetmap.org/</link>
<item>
<title>reactivated note (near 33415, Verl, Kreis Gütersloh, North
Rhine-Westphalia, Germany)</title>
<link>https://www.openstreetmap.org/note/3741743#c10178362</link>
<guid>https://www.openstreetmap.org/note/3741743#c10178362</guid>
<description>
</code></pre>
<p dir="auto">I believe the problem is here, when adding an object (e.g. Changeset or Note) to the map:</p>
<p dir="auto"><a href="https://github.com/openstreetmap/openstreetmap-website/blob/5ca24de0d04bef18353d3f0ecdd069d0bca34ce2/app/assets/javascripts/index.js#L312-L315">https://github.com/openstreetmap/openstreetmap-website/blob/5ca24de0d04bef18353d3f0ecdd069d0bca34ce2/app/assets/javascripts/index.js#L312-L315</a></p>
<p dir="auto">This code decides whether to move the map to display the object. It will only move the map if there are not a hash fragment in the url (<code class="notranslate">!window.location.hash</code>). The implicit assumption here is that if there <strong>is</strong> a fragment, that the fragment is a location (e.g. <code class="notranslate">#map=0/0/0</code>. The bug is that there might be other hash fragments, such as a comment id.</p>
<p dir="auto">cc <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/flohoff/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/flohoff">@flohoff</a></p><p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/issues/865#issuecomment-2660929224">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJ4IDSKPJYP5LRMT4T2P47LNAVCNFSM6AAAAABM6YK42SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRQHEZDSMRSGQ">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLJP6XXFU6IWXFBIHAD2P47LNA5CNFSM6AAAAABM6YK42SWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTU6TKHMQ.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/issues/865/2660929224</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
</span>
<div style="display: flex; flex-wrap: wrap; white-space: pre-wrap; align-items: center; "><img alt="gravitystorm" height="20" width="20" style="border-radius:50%; margin-right: 4px;" decoding="async" src="https://avatars.githubusercontent.com/u/360803?s=20&v=4" /><strong>gravitystorm</strong> left a comment <a href="https://github.com/openstreetmap/openstreetmap-website/issues/865#issuecomment-2660929224">(openstreetmap/openstreetmap-website#865)</a></div>
<p dir="auto">This is also a problem with the notes comment feed, which contains links with fragments (targetting the comment id).</p>
<p dir="auto"><code class="notranslate">curl https://www.openstreetmap.org/api/0.6/notes/feed?bbox=8.1706155,51.8144663,8.5269845,51.9737924</code></p>
<pre class="notranslate"><code class="notranslate"><?xml version="1.0" encoding="UTF-8"?>
<rss version="2.0" xmlns:dc=["http://purl.org/dc/elements/1.1/"](http://purl.org/dc/elements/1.1/)
xmlns:geo=["http://www.w3.org/2003/01/geo/wgs84_pos#"](http://www.w3.org/2003/01/geo/wgs84_pos#)
xmlns:georss=["http://www.georss.org/georss"](http://www.georss.org/georss)>
<channel>
<title>OpenStreetMap Notes</title>
<description>A list of notes, reported, commented on or closed in
your area [(51.8144663|8.1706155) --
(51.9737924|8.5269845)]</description>
<link>https://www.openstreetmap.org/</link>
<item>
<title>reactivated note (near 33415, Verl, Kreis Gütersloh, North
Rhine-Westphalia, Germany)</title>
<link>https://www.openstreetmap.org/note/3741743#c10178362</link>
<guid>https://www.openstreetmap.org/note/3741743#c10178362</guid>
<description>
</code></pre>
<p dir="auto">I believe the problem is here, when adding an object (e.g. Changeset or Note) to the map:</p>
<p dir="auto"><a href="https://github.com/openstreetmap/openstreetmap-website/blob/5ca24de0d04bef18353d3f0ecdd069d0bca34ce2/app/assets/javascripts/index.js#L312-L315">https://github.com/openstreetmap/openstreetmap-website/blob/5ca24de0d04bef18353d3f0ecdd069d0bca34ce2/app/assets/javascripts/index.js#L312-L315</a></p>
<p dir="auto">This code decides whether to move the map to display the object. It will only move the map if there are not a hash fragment in the url (<code class="notranslate">!window.location.hash</code>). The implicit assumption here is that if there <strong>is</strong> a fragment, that the fragment is a location (e.g. <code class="notranslate">#map=0/0/0</code>. The bug is that there might be other hash fragments, such as a comment id.</p>
<p dir="auto">cc <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/flohoff/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/flohoff">@flohoff</a></p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/issues/865#issuecomment-2660929224">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJ4IDSKPJYP5LRMT4T2P47LNAVCNFSM6AAAAABM6YK42SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRQHEZDSMRSGQ">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLJP6XXFU6IWXFBIHAD2P47LNA5CNFSM6AAAAABM6YK42SWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTU6TKHMQ.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/issues/865/2660929224</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/issues/865#issuecomment-2660929224",
"url": "https://github.com/openstreetmap/openstreetmap-website/issues/865#issuecomment-2660929224",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>