<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5344#discussion_r1957319509">app/models/note_tag.rb</a>:</p>
<pre style='color:#555'>> +# Table name: note_tags
+#
+# note_id :bigint(8) not null, primary key
+# k :string default(""), not null, primary key
+# v :string default(""), not null
+#
+# Foreign Keys
+#
+# note_tags_id_fkey (note_id => notes.id)
+#
+
+class NoteTag < ApplicationRecord
+ belongs_to :note
+
+ validates :note, :associated => true
+ validates :k, :v, :allow_blank => true, :length => { :maximum => 255 }, :characters => true
</pre>
<p dir="auto">Why are we allowing blank values? Possibly there's an argument for a blank value but certainly not for a key?</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5344#discussion_r1957319581">db/migrate/20241030122707_create_note_tags.rb</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,12 @@
+class CreateNoteTags < ActiveRecord::Migration[7.2]
+ def change
+ # Create a table, primary and foreign keys
+ create_table :note_tags, :primary_key => [:note_id, :k] do |t|
+ t.column "note_id", :bigint, :null => false
+ t.column "k", :string, :default => "", :null => false
+ t.column "v", :string, :default => "", :null => false
</pre>
<p dir="auto">Do these really need a default value?</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5344#pullrequestreview-2619620938">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJSWXUU7SP2OM5KQPD2QCDSXAVCNFSM6AAAAABSCG2KCWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMMJZGYZDAOJTHA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLPOOIXBISB464YCS232QCDSXA5CNFSM6AAAAABSCG2KCWWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTU4EQ7EU.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5344/review/2619620938</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5344#pullrequestreview-2619620938",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5344#pullrequestreview-2619620938",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>