<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>

<p dir="auto">I'm not sure there's a good reason for the step by step change of <code class="notranslate">edit_account_path</code> to <code class="notranslate">account_path</code> here... I'd be inclined to squash all that down into the main commit (which already changes some uses) and just have the two preparatory commits and the one main commit.</p><hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5696#discussion_r1957827433">config/routes.rb</a>:</p>
<pre style='color:#555'>>      scope :module => :accounts do
       resource :terms, :only => [:show, :update]
       resource :pd_declaration, :only => [:show, :create]
       resource :deletion, :only => :show
       resource :home, :only => :show
     end
   end
+  get "/account/edit", :to => redirect(:path => "/account"), :as => nil
</pre>
<p dir="auto">Do we actually need this redirect? Are we expecting sites outside openstreetmap.org to have direct links to the account edit page?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5696#pullrequestreview-2620378439">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLMDJBXTBEDPTEMYPWT2QGO2BAVCNFSM6AAAAABXIEN5WSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMMRQGM3TQNBTHE">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLJ4CI5YTWXWNJ3D4YD2QGO2BA5CNFSM6AAAAABXIEN5WSWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTU4F7GUO.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5696/review/2620378439</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5696#pullrequestreview-2620378439",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5696#pullrequestreview-2620378439",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>