<span style="color: transparent; display: none; height: 0; max-height: 0; max-width: 0; opacity: 0; overflow: hidden; mso-hide: all; visibility: hidden; width: 0;">
<blockquote>
<p dir="auto">The map parameter would always be set.</p>
</blockquote>
<p dir="auto">not in the iframe's <code class="notranslate">src</code> parameter before <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/openstreetmap/openstreetmap-website/commit/5310c5b9dd67f7d416ee778a36f43c21126a1575/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/commit/5310c5b9dd67f7d416ee778a36f43c21126a1575"><tt>5310c5b</tt></a> 🤷<br>
<a href="https://github.com/user-attachments/assets/66e6eb98-4f6b-40a9-a90e-a6a58a31b196">image.png (view on web)</a></p>
<blockquote>
<p dir="auto">Why would you not want to use the coordinates for nodes, ways and notes if these are already loaded in the <a href="https://github.com/openstreetmap/openstreetmap-website/blob/483f4c1341ee2b0eb438dc7704e4ba272d1e74fe/app/controllers/site_controller.rb#L86">site_controller</a>?</p>
</blockquote>
<p dir="auto">Ok, wait. Of course it would be good to load the editor right away at the correct coordinates. For nodes and notes this is trivial (we can use the <code class="notranslate">lat</code>/<code class="notranslate">lon</code> directly), not sure how doable it would be in the ruby code for ways and relations, as there would be some zoom-level calculation to do (which depends on the size of the feature as well as the size of the browser window and the applied browser-zoom %).</p>
<p dir="auto">What I was trying to do here is to merely fix the regression from <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2840204563" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/5632" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/5632/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/5632">#5632</a> by restoring the previous behavior, and nothing more. If you can come up with a better fix, please go ahead, I'm happy to close this one in favor of a better solution.</p><p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5698#issuecomment-2663993901">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLP3FU3KJUPGIZSRO3D2QI6W3AVCNFSM6AAAAABXI34LQGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRTHE4TGOJQGE">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLNIK7H6FMPALZZTWYD2QI6W3A5CNFSM6AAAAABXI34LQGWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTU6ZFJC2.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5698/c2663993901</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
</span>
<div style="display: flex; flex-wrap: wrap; white-space: pre-wrap; align-items: center; "><img alt="tyrasd" height="20" width="20" style="border-radius:50%; margin-right: 4px;" decoding="async" src="https://avatars.githubusercontent.com/u/1927298?s=20&v=4" /><strong>tyrasd</strong> left a comment <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5698#issuecomment-2663993901">(openstreetmap/openstreetmap-website#5698)</a></div>
<blockquote>
<p dir="auto">The map parameter would always be set.</p>
</blockquote>
<p dir="auto">not in the iframe's <code class="notranslate">src</code> parameter before <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/openstreetmap/openstreetmap-website/commit/5310c5b9dd67f7d416ee778a36f43c21126a1575/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/commit/5310c5b9dd67f7d416ee778a36f43c21126a1575"><tt>5310c5b</tt></a> 🤷<br>
<a href="https://github.com/user-attachments/assets/66e6eb98-4f6b-40a9-a90e-a6a58a31b196">image.png (view on web)</a></p>
<blockquote>
<p dir="auto">Why would you not want to use the coordinates for nodes, ways and notes if these are already loaded in the <a href="https://github.com/openstreetmap/openstreetmap-website/blob/483f4c1341ee2b0eb438dc7704e4ba272d1e74fe/app/controllers/site_controller.rb#L86">site_controller</a>?</p>
</blockquote>
<p dir="auto">Ok, wait. Of course it would be good to load the editor right away at the correct coordinates. For nodes and notes this is trivial (we can use the <code class="notranslate">lat</code>/<code class="notranslate">lon</code> directly), not sure how doable it would be in the ruby code for ways and relations, as there would be some zoom-level calculation to do (which depends on the size of the feature as well as the size of the browser window and the applied browser-zoom %).</p>
<p dir="auto">What I was trying to do here is to merely fix the regression from <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2840204563" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/5632" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/5632/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/5632">#5632</a> by restoring the previous behavior, and nothing more. If you can come up with a better fix, please go ahead, I'm happy to close this one in favor of a better solution.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5698#issuecomment-2663993901">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLP3FU3KJUPGIZSRO3D2QI6W3AVCNFSM6AAAAABXI34LQGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRTHE4TGOJQGE">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLNIK7H6FMPALZZTWYD2QI6W3A5CNFSM6AAAAABXI34LQGWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTU6ZFJC2.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5698/c2663993901</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5698#issuecomment-2663993901",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5698#issuecomment-2663993901",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>