<p></p>
<p><b>@AntonKhorev</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5439#discussion_r1958496889">app/views/social_links/_show.html.erb</a>:</p>
<pre style='color:#555'>> + <div class="text-body-secondary d-flex mb-3">
+ <%= image_tag "social_link_icons/#{social_link.parsed[:platform].nil? ? 'other' : social_link.parsed[:platform]}.svg",
+ :alt => social_link.parsed[:platform].nil? ? "other" : social_link.parsed[:platform],
+ :class => "me-2" %>
+ <%= link_to social_link.parsed[:name], social_link.url, :class => "text-body-secondary d-block text-truncate", :rel => "nofollow me" %>
+ </div>
</pre>
<p dir="auto">What do you think about this?</p>
⬇️ Suggested change
<pre style="color: #555">- <div class="text-body-secondary d-flex mb-3">
- <%= image_tag "social_link_icons/#{social_link.parsed[:platform].nil? ? 'other' : social_link.parsed[:platform]}.svg",
- :alt => social_link.parsed[:platform].nil? ? "other" : social_link.parsed[:platform],
- :class => "me-2" %>
- <%= link_to social_link.parsed[:name], social_link.url, :class => "text-body-secondary d-block text-truncate", :rel => "nofollow me" %>
- </div>
+ <%= link_to social_link.url, :class => "icon-link mw-100 text-body-secondary mb-3", :rel => "nofollow me" do %>
+ <%= image_tag "social_link_icons/#{social_link.parsed[:platform].nil? ? 'other' : social_link.parsed[:platform]}.svg",
+ :alt => social_link.parsed[:platform].nil? ? "other" : social_link.parsed[:platform],
+ :size => "16" %>
+ <span class="text-truncate">
+ <%= social_link.parsed[:name] %>
+ </span>
+ <% end %>
</pre>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5439#pullrequestreview-2621496626">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLMQ2R4OGEZFKPTOWYD2QID2BAVCNFSM6AAAAABUCYTSJCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMMRRGQ4TMNRSGY">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLLGV47P6JK37SIXZQD2QID2BA5CNFSM6AAAAABUCYTSJCWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTU4IDOTE.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5439/review/2621496626</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5439#pullrequestreview-2621496626",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5439#pullrequestreview-2621496626",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>