<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5694#discussion_r1957874653">app/assets/javascripts/index/directions.js</a>:</p>
<pre style='color:#555'>> @@ -36,6 +36,9 @@ OSM.Directions = function (map) {
OSM.DirectionsEndpoint(map, $("input[name='route_to']"), OSM.MARKER_RED, endpointDragCallback, endpointChangeCallback)
];
+ const exportGroup = L.layerGroup([...endpoints.map(m => m.marker), polyline]);
+ let downloadURL = null;
+
</pre>
<p dir="auto">Does this code need to be here, or can we move it down to be with the other code?</p>
<p dir="auto">My concern is that the second code block makes assumptions about how the order of features in the layer group relates to the endpoints array that is established by this code and I can't see a good way to avoid that so I'd at least like to keep all the code together if we can.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5694#pullrequestreview-2620457669">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLNZTIAUIZJUDOKTTEL2QGSJNAVCNFSM6AAAAABXHXUPCSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMMRQGQ2TONRWHE">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLNCCTE3LML4RKLD4XD2QGSJNA5CNFSM6AAAAABXHXUPCSWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTU4GEBMK.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5694/review/2620457669</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5694#pullrequestreview-2620457669",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5694#pullrequestreview-2620457669",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>