<p></p>
<p><b>@hlfan</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5652#discussion_r1963036951">app/assets/javascripts/index/directions.js</a>:</p>
<pre style='color:#555'>> + modeGroup.html("");
+ for (const mode of new Set(modes)) {
+ modeGroup.append(`<input type="radio" class="btn-check" name="modes" id="${mode}" autocomplete="off">`);
+ modeGroup.append(`<label class="btn btn-outline-secondary px-2" for="${mode}" title="${
+ I18n.t("javascripts.directions.modes." + mode)
+ }"><svg class="d-block" width="16" height="16" fill="currentColor"><path d="${modeIconPaths[mode]}"></path></svg></label>`);
+ }
</pre>
<p dir="auto">Disabling the buttons and the selects options seems better, disabling all in the template and enabling each in js when supported.</p>
<p dir="auto">However, I don't want to move too much to be hardcoded like it was already criticized in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1083953802" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/3400" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/3400/hovercard?comment_id=1057225749&comment_type=issue_comment" href="https://github.com/openstreetmap/openstreetmap-website/pull/3400#issuecomment-1057225749">#3400 (comment)</a></p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5652#discussion_r1963036951">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLOLCAWYSI7PUHDMH5D2QWEDBAVCNFSM6AAAAABW4RZANOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMMRYHE4TSNRUHE">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLMVFAMEIAQVUKZMWG32QWEDBA5CNFSM6AAAAABW4RZANOWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTU4WNM6C.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5652/review/2628999649</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5652#discussion_r1963036951",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5652#discussion_r1963036951",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>