<p></p>
<p><b>@nertc</b> commented on this pull request.</p>
<p dir="auto">Tested and works perfectly for all kinds of situations. I like the last solution that UI watches only author and the last comment. It provides intuitive UI/UX.</p><hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5269#discussion_r1965125704">app/views/notes/index.html.erb</a>:</p>
<pre style='color:#555'>> @@ -24,7 +26,15 @@
</tr>
</thead>
<% @notes.each do |note| -%>
- <tr<% if note.author == @user %> class="table-primary"<% end %>>
+ <% opened_by_user = note.author == @user %>
+ <% closed_by_user = note.comments.last&.author == @user && note.comments.last&.event == "closed" %>
</pre>
<p dir="auto">As I checked, mostly variables created in the <code class="notranslate">.html.erb</code> files directly have meaning of either class, id or other values that are only related to the UI and not to the logic. Is it okay for this project to have variables that are intermediate logical elements and don't have direct value of class, id or other strings like that?</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5269#pullrequestreview-2632444055">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLMK2AI526J6R3CYJ7T2Q3VDXAVCNFSM6AAAAABQDTUCRCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMMZSGQ2DIMBVGU">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLM23DKFEJ7QMDSO3GD2Q3VDXA5CNFSM6AAAAABQDTUCRCWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTU447UJO.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5269/review/2632444055</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5269#pullrequestreview-2632444055",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5269#pullrequestreview-2632444055",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>