<p></p>
<p><b>@HolgerJeromin</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5731#discussion_r1974953260">app/assets/javascripts/leaflet.key.js</a>:</p>
<pre style='color:#555'>> +        .then(html => $section.html(html))
+        .then(update);
</pre>
<p dir="auto">Right now <code class="notranslate">update</code> will get the html from the <code class="notranslate">.html(html)</code> <a href="https://api.jquery.com/html/#html2" rel="nofollow">jquery call</a>.<br>
This would prevent "leaking" the data into the next promise chain:</p>
⬇️ Suggested change
<pre style="color: #555">-        .then(html => $section.html(html))
-        .then(update);
+        .then(html => {
+             $section.html(html)
+             return;
+           })
+        .then(update);
</pre>


<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5731#pullrequestreview-2649992818">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLNSRBTR56YENNJSGKL2SAH5JAVCNFSM6AAAAABYBBMA6WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMNBZHE4TEOBRHA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLIM2DWOS3V7BBJY2ID2SAH5JA5CNFSM6AAAAABYBBMA6WWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTU56OXHE.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5731/review/2649992818</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5731#pullrequestreview-2649992818",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5731#pullrequestreview-2649992818",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>