<p dir="auto">Currently we have in use:</p>
<ul dir="auto">
<li><code class="notranslate">location</code></li>
<li><code class="notranslate">window.location</code></li>
<li><code class="notranslate">document.location</code></li>
</ul>
<p dir="auto">The only one that's missing is <code class="notranslate">window.document.location</code>. These are <a href="https://stackoverflow.com/questions/2430936/whats-the-difference-between-window-location-and-document-location" rel="nofollow">mostly the same</a>.</p>
<p dir="auto">We can just use <code class="notranslate">location</code> everywhere because it's shorter.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/openstreetmap/openstreetmap-website/pull/5739'>https://github.com/openstreetmap/openstreetmap-website/pull/5739</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5739/commits/4e9483e5eb8af1ee125b3ada96c5fa716176c490" class="commit-link">4e9483e</a> Use location instead of window.location and document.location</li>
</ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5739/files">14 files</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5739/files#diff-8c15a01c0063fe88fd9f5197128e788856295e4755fbb4a3cbf7aa6be9f81ca7">app/assets/javascripts/embed.js.erb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5739/files#diff-cdc070ced1c4000efd1e28357fd26b2fd617d7fccfeae0324222231db75dd6ee">app/assets/javascripts/index.js</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5739/files#diff-e8b0bd562b0aaead17e44d572d51fcc72fa846c7b54ae5df2dc6434fb80834dc">app/assets/javascripts/index/changeset.js</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5739/files#diff-fdb9558c2ba79ddf9fbcb92594a8a8fa54abb1b3e25ce264de37951b428a958b">app/assets/javascripts/index/directions.js</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5739/files#diff-25cab16df4a58e0c8e53d0a0e70d9bbf28ef3beb9e6bf1208234fdeed7515392">app/assets/javascripts/index/history.js</a>
(8)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5739/files#diff-8f18485b763264500054435af432745e2a51b4402140728dc4df89024768b71b">app/assets/javascripts/index/note.js</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5739/files#diff-8275a6df0995b2af17f0b52a0dfe5a00f8b09d9d51b89516e2612a3faa9d8c0f">app/assets/javascripts/index/query.js</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5739/files#diff-f060eef487077b042f45b3a12e7a2cbd54a446f8c744cdb98405a1295430e8b9">app/assets/javascripts/leaflet.map.js</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5739/files#diff-45b32fb630c4dedc980d452167de5634dfad0500a1bec34bc843e018954c6876">app/assets/javascripts/login.js</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5739/files#diff-b4ab8abdaadce7c3669db5cab989cc982c840ee387ce65a755d0a0ef859097cf">app/assets/javascripts/matomo.js</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5739/files#diff-a9b88a8a3644f944b9bd54361da588c69fa6a210cf7327194c17895a8ad2b0d6">app/assets/javascripts/osm.js.erb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5739/files#diff-3635093596ec53c4cebe7c2263939a5b01c8b9c71462506873f73af8429cabbc">app/assets/javascripts/router.js</a>
(8)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5739/files#diff-b84ee037ee4159b0b5331506806797468159d9962a0640ad27cc474e7c8b6a77">app/assets/javascripts/welcome.js</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5739/files#diff-94f48fb5b77f2e9e4d66ccbe5276b249c97182801b5213c866b744316d737a9f">test/javascripts/osm_test.js</a>
(6)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/5739.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/5739.patch</a></li>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/5739.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/5739.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5739">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLK6EQFIAQYDGQR3HF32SF3IDAVCNFSM6AAAAABYD4M73OVHI2DSMVQWIX3LMV43ASLTON2WKOZSHA4DQNZVGYZDQOI">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLNY7FVZ742JHXUMYQD2SF3IDA5CNFSM6AAAAABYD4M73OWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHKYLXMIE.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5739</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5739",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5739",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>