<h3 dir="auto">Description</h3>
<p dir="auto">PR removes optional using of note's first comments records for retrieving note's description and author in Note model file.</p>
<p dir="auto">Also, adds note's initializing when created using <code class="notranslate">note_comments</code> factory by initializing note's <code class="notranslate">description</code>, <code class="notranslate">user_ip</code> and <code class="notranslate">user_id</code> from note's comment (this is used only when notes are created by <code class="notranslate">create(:note_comment, ...)</code>) in unit tests.</p>
<h3 dir="auto">How has this been tested?</h3>
<p dir="auto">Automated unit tests and manual testing on previously created set of notes (with special cases).</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/openstreetmap/openstreetmap-website/pull/5744'>https://github.com/openstreetmap/openstreetmap-website/pull/5744</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5744/commits/c3e8a2efd2c9adfc767479112051435849328502" class="commit-link">c3e8a2e</a> Removes optional using first comments records</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5744/commits/c44ed54fc77419ecf342225005e754f05a4502e2" class="commit-link">c44ed54</a> Improves initializing note's records in test factory</li>
</ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5744/files">3 files</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5744/files#diff-08ddccf408b18937e98b422e555eaf851c2a02c3ba815c5aeb8bc00efe65ecab">app/models/note.rb</a>
(17)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5744/files#diff-98398a8a1dab8650c77983ee32006ee5d085b23e9108b6d995307112327009b0">test/factories/note_comments.rb</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5744/files#diff-b93fe6b2fae5309f99ba81772f10cf26c2d05ce9eb923b430a03de6121951964">test/models/note_test.rb</a>
(9)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/5744.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/5744.patch</a></li>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/5744.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/5744.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5744">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLO5TWLXB3FP4OUARWL2SSQLRAVCNFSM6AAAAABYHW6UE6VHI2DSMVQWIX3LMV43ASLTON2WKOZSHA4TEMBUGI4TEMY">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLIDICVSX6WLKT6OPLD2SSQLRA5CNFSM6AAAAABYHW6UE6WGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHKYYISVM.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5744</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5744",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5744",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>