<span style="color: transparent; display: none; height: 0; max-height: 0; max-width: 0; opacity: 0; overflow: hidden; mso-hide: all; visibility: hidden; width: 0;">
  <p dir="auto">I don't think this is the right approach to the tests - a factory that modifies the record's parent seems wrong to me.</p>
<p dir="auto">Probably the <code class="notranslate">note_comment</code> factory shouldn't be defaulting to creating an <code class="notranslate">opened</code> comment now, as in the future there won't be any such thing. It should probably default to <code class="notranslate">commented</code> and the <code class="notranslate">note</code> factory should generate food defaults for the initial open and tests should be adapted to all that.</p><p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5744#issuecomment-2695474775">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLOLLJRRRDV3HX75J732SS4DPAVCNFSM6AAAAABYHW6UE6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOJVGQ3TINZXGU">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLPEDCOCGQULPHKO6F32SS4DPA5CNFSM6AAAAABYHW6UE6WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTVAVGXFO.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5744/c2695474775</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
</span>


<div style="display: flex; flex-wrap: wrap; white-space: pre-wrap; align-items: center; "><img alt="tomhughes" height="20" width="20" style="border-radius:50%; margin-right: 4px;" decoding="async" src="https://avatars.githubusercontent.com/u/147741?s=20&v=4" /><strong>tomhughes</strong> left a comment <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5744#issuecomment-2695474775">(openstreetmap/openstreetmap-website#5744)</a></div>
<p dir="auto">I don't think this is the right approach to the tests - a factory that modifies the record's parent seems wrong to me.</p>
<p dir="auto">Probably the <code class="notranslate">note_comment</code> factory shouldn't be defaulting to creating an <code class="notranslate">opened</code> comment now, as in the future there won't be any such thing. It should probably default to <code class="notranslate">commented</code> and the <code class="notranslate">note</code> factory should generate food defaults for the initial open and tests should be adapted to all that.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5744#issuecomment-2695474775">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLOLLJRRRDV3HX75J732SS4DPAVCNFSM6AAAAABYHW6UE6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOJVGQ3TINZXGU">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLPEDCOCGQULPHKO6F32SS4DPA5CNFSM6AAAAABYHW6UE6WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTVAVGXFO.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5744/c2695474775</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>

<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5744#issuecomment-2695474775",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5744#issuecomment-2695474775",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>