<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5744#discussion_r1980007696">test/models/note_test.rb</a>:</p>
<pre style='color:#555'>>      comment = create(:note_comment, :author => user)
-    assert_equal user, comment.note.author
+    assert_equal "Default note's description", comment.note.description
</pre>
<p dir="auto">Why move this from <code class="notranslate">test_author</code> to <code class="notranslate">test_description</code> exactly?</p>
<p dir="auto">I mean obviously it is now testing the description, but why? It just seems to be duplicating the testing that's already done (unless you expect setting the author to change the behaviour of description) while not actually testing <code class="notranslate">author</code> at all anymore?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5744#pullrequestreview-2658597673">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJWIKJND3ZLGV3BVP32SXW53AVCNFSM6AAAAABYHW6UE6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMNJYGU4TONRXGM">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLKDAOYXRLDZGJPGJ2T2SXW53A5CNFSM6AAAAABYHW6UE6WGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTU6O35SS.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5744/review/2658597673</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5744#pullrequestreview-2658597673",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5744#pullrequestreview-2658597673",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>