<p></p>
<p><b>@tomhughes</b> requested changes on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5752#discussion_r1982273349">app/views/site/fixthemap.html.erb</a>:</p>
<pre style='color:#555'>> @@ -22,7 +22,15 @@
   <div class='col-sm'>
     <h3 class='fs-5'><%= t "site.welcome.add_a_note.title" %></h3>
     <p><%= t "site.welcome.add_a_note.para_1" %></p>
-    <p><%= t ".how_to_help.add_a_note.instructions_1_html", :note_icon => tag.a(:class => "icon note bg-dark rounded-1") %></p>
+    <p><%= t(
+             ".how_to_help.add_a_note.instructions_1_html",
+             :note_icon => link_to(
+               tag.svg(:width => "20", :height => "20", :fill => "currentColor", :class => "align-top") do
+                 tag.path(:d => "M17 12H15v2H13v2h2v2h2V16h2V14H17V12ZM3 12H6l2 3 2-3h3l1-1V4L13 3H3L2 4v7Z")
+               end,
+               "/note/new"
</pre>
<p dir="auto">This should use <code class="notranslate">new_note_path</code> rather than hardcoding the link.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5752#discussion_r1982276445">app/assets/javascripts/fixthemap.js</a>:</p>
<pre style='color:#555'>>    if (!params.zoom) params.zoom = 17;
-  if (params.lat && params.lon) url += OSM.formatHash(params);
-  $(".icon.note").attr("href", url);
+  if (params.lat && params.lon) {
+    $("a[href*='note']")[0].href += OSM.formatHash(params);
</pre>
<p dir="auto">This is rather nasty as it means this code is having to make assumptions about the URL that has been filled in by the server, plus we're hoping that no other links contain <code class="notranslate">note</code> anywhere... Can we not mark the element with a class that can be used to pick it out precisely?</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5752#discussion_r1982278793">app/assets/stylesheets/common.scss</a>:</p>
<pre style='color:#555'>>  
-  .icon {
-    margin: 10px;
-  }
+.leaflet-control.active .control-button {
+  background-color: $vibrant-green;
+}
+
+.geolocate {
+       background: currentColor;
+       clip-path: polygon(20% 50%, 20% 40%, 70% 20%, 80% 20%, 80% 30%, 60% 80%, 50% 80%, 50% 50%);
</pre>
<p dir="auto">Indentation is wrong here - think it's using a tab or something?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5752#pullrequestreview-2662640390">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLOL4Z36DRNGQH2GTMT2S53IJAVCNFSM6AAAAABYM6ZM26VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMNRSGY2DAMZZGA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLIZ6USE4O7RF725FZT2S53IJA5CNFSM6AAAAABYM6ZM26WGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTU6WSVQM.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5752/review/2662640390</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5752#pullrequestreview-2662640390",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5752#pullrequestreview-2662640390",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>