<p dir="auto"><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2354285712" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/4901" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/4901/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/4901">#4901</a> v2</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/openstreetmap/openstreetmap-website/pull/5753'>https://github.com/openstreetmap/openstreetmap-website/pull/5753</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5753/commits/96a12196bfc234af10b6cbda305f2bb9b48a07ee" class="commit-link">96a1219</a> Separate setting/clearing listeners/values on directions endpoints</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5753/commits/0ba8ac49f6815db5a971776f4960f16549d18645" class="commit-link">0ba8ac4</a> Move directions params init code to its own function</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5753/commits/1c66d7f50fe4d8ef22771f99d8690bc5136f30b7" class="commit-link">1c66d7f</a> Move directions listeners init code to its own function</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5753/commits/642d7e800db4eb6ef30b7817233ef37fac26b3c6" class="commit-link">642d7e8</a> Write directions sidebar header using .erb template</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5753/commits/c6f106cc346b5624bf7dde0f9484f46ee4285713" class="commit-link">c6f106c</a> Hide loader spinner when sidebar content is not displayed</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5753/commits/48d1abdf92ea2172db829ad0614fe2c8e8990ee6" class="commit-link">48d1abd</a> Move directions title out of javascript i18n strings</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5753/commits/b6b4d55e19c37b505f21fdc8901981f7fd0ee3fc" class="commit-link">b6b4d55</a> Use svg symbols for routing icons</li>
</ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5753/files">11 files</a>)</p>
<ul>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5753/files#diff-f37d2e1cc8c9eb5d441c27d74864e85daeed2b4a53b4f609d0292cbdecfef778">app/assets/images/routing-sprite.svg</a>
(55)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5753/files#diff-cdc070ced1c4000efd1e28357fd26b2fd617d7fccfeae0324222231db75dd6ee">app/assets/javascripts/index.js</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5753/files#diff-720e11d91a0c3a64a70dd6bfad46c242e9f4755b2470797031de5b55ff9a8c5d">app/assets/javascripts/index/directions-endpoint.js</a>
(20)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5753/files#diff-fdb9558c2ba79ddf9fbcb92594a8a8fa54abb1b3e25ce264de37951b428a958b">app/assets/javascripts/index/directions.js</a>
(96)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5753/files#diff-7e2536f2e9b6f209b368993e27a7ecbb60869fc394321af9c2d735c8c02e8fa9">app/assets/javascripts/index/directions/fossgis_osrm.js</a>
(50)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5753/files#diff-a9cecd581b2c9e4e43ee8e0b73ee178a13779019da8bcb9c13d209843c716711">app/assets/javascripts/index/directions/fossgis_valhalla.js</a>
(64)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5753/files#diff-ef6651e3e37e12a6ee24e6c9efaa98ddd129a20a5631401cea6e0642fcfffb7a">app/assets/javascripts/index/directions/graphhopper.js</a>
(32)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5753/files#diff-e86a39e6d0b163f152db8843fc7d647a3f5d648de4a74f1732bef4474b6e5bc8">app/assets/stylesheets/common.scss</a>
(21)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5753/files#diff-8a114414669453ee10afc6603077a733d82cbe1cfea93d921414abd72ef1356f">app/views/directions/search.html.erb</a>
(81)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5753/files#diff-eaeaf6b733bc454c8c41be224e85cdca90bc6e0e5bc1f02f9f86315cfc6fafab">app/views/layouts/map.html.erb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5753/files#diff-44438ce218f5287c58d0017f965d888715635d94280669896f75841fbd7b4cd7">config/locales/en.yml</a>
(4)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/5753.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/5753.patch</a></li>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/5753.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/5753.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5753">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLKGWHOBR6KEJBF274D2TALPZAVCNFSM6AAAAABYOHUDUWVHI2DSMVQWIX3LMV43ASLTON2WKOZSHA4TSOJRHAYDAMI">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLLNZIRSVYQSBD3ZO332TALPZA5CNFSM6AAAAABYOHUDUWWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHKZWJ4WE.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5753</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5753",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5753",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>