<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5745#discussion_r1986099152">app/assets/javascripts/application.js</a>:</p>
<pre style='color:#555'>> @@ -21,7 +21,6 @@
I18n.default_locale = OSM.DEFAULT_LOCALE;
I18n.locale = locale;
- I18n.fallbacks = true;
</pre>
<p dir="auto">As I explained when I opened this PR the embed case is different - there we load <code class="notranslate">embed.js</code> which contains only a single string but does contain all languages - we do it that way because language selection has to happen client side.</p>
<p dir="auto">That said I just realised that although it contains all languages it has already applied fallback to them, so there is no opportunity to do client fallback.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5745#discussion_r1986099152">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLPB2YLPGQRLFULJEUT2TMB33AVCNFSM6AAAAABYIEQ23CVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMNRZGIYDOMJQGY">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLPVNQONALAAEUSBUML2TMB33A5CNFSM6AAAAABYIEQ23CWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTU7DDPEE.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5745/review/2669207106</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5745#discussion_r1986099152",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5745#discussion_r1986099152",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>