<p></p>
<p><b>@tomhughes</b> requested changes on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5402#discussion_r1986287881">app/assets/javascripts/heatmap.js</a>:</p>
<pre style='color:#555'>> +
+ let cal = new CalHeatmap();
+ let currentTheme = getTheme();
+
+ function renderHeatmap() {
+ cal.destroy();
+ cal = new CalHeatmap();
+
+ cal.paint({
+ itemSelector: "#cal-heatmap",
+ theme: currentTheme,
+ domain: {
+ type: "month",
+ gutter: 4,
+ label: {
+ text: (timestamp) => I18n.strftime(new Date(2000, new Date(timestamp).getMonth(), 15), "%b"),
</pre>
<p dir="auto">If we've constructed a date from the timestamp why do you then extract the month from that and build a new date? If the format only uses the month the rest of the date doesn't matter?</p>
<p dir="auto">It might a bit faster to just lookup <code class="notranslate">I18n.t("date.abbr_month_names")</code> once before the paint call and then index that array with the month number rather than calling strftime repeatedly - just beware of 0/1 based indexing!</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5402#pullrequestreview-2669390875">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLLLHGVTKTKUKCKL6BL2TQMSFAVCNFSM6AAAAABTWNRZO6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMNRZGM4TAOBXGU">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLNNEAUZSGN6HKWAG4L2TQMSFA5CNFSM6AAAAABTWNRZO6WGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTU7DOWBW.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5402/review/2669390875</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5402#pullrequestreview-2669390875",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5402#pullrequestreview-2669390875",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>