<p></p>
<p><b>@AntonKhorev</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5736#discussion_r1988865392">app/assets/javascripts/osm.js.erb</a>:</p>
<pre style='color:#555'>> @@ -80,6 +80,11 @@ OSM = {
const hash = OSM.parseHash(location.hash);
+ const geoURI = Object.fromEntries(new URLSearchParams(
+ params.geouri?.replaceAll(/[?;]/g, "&")?.replace(":", "=")
</pre>
<p dir="auto">If you don't need <code class="notranslate">u</code>, you don't need any regexps.</p>
<p dir="auto">If you need <code class="notranslate">u</code>, that parameter can't have <code class="notranslate">&</code> inside and you can have a simpler regexp. But do you need <code class="notranslate">u</code>? Are you going to show the uncertainty?</p>
<p dir="auto">If you want to parse <em>every</em> parameter, you'll need a complicated regexp. What do you need other parameters for?</p>
<p dir="auto"><code class="notranslate">z</code> is not a RFC 5870 parameter.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5736#discussion_r1988865392">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLOMIUMMLQJLODOBKYT2T2YBLAVCNFSM6AAAAABYDP55XWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMNZTG4ZDINBTGE">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLPVLPZ5LJMMJ7MRB632T2YBLA5CNFSM6AAAAABYDP55XWWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTU7LXGA6.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5736/review/2673724431</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5736#discussion_r1988865392",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5736#discussion_r1988865392",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>