<p></p>
<p><b>@hlfan</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5736#discussion_r1991795477">app/assets/javascripts/osm.js.erb</a>:</p>
<pre style='color:#555'>> @@ -100,6 +106,9 @@ OSM = {
mapParams.lon = params.mlon;
mapParams.lat = params.mlat;
mapParams.zoom = params.zoom || 12;
+ } else if (geoURI.pathname) {
+ [mapParams.lat, mapParams.lon] = geoURI.pathname.split(",");
</pre>
<p dir="auto">I thought we wouldn't parse these parameters with the move to <code class="notranslate">new URL</code> and parseFloat takes care of these things anyway.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5736#discussion_r1991795477">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLOU2GULDOGUNIJNUCL2UBJLLAVCNFSM6AAAAABYDP55XWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMNZZGAYTGMRXHA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLKJCG632QJNHXL3N6D2UBJLLA5CNFSM6AAAAABYDP55XWWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTU7VZ7Z4.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5736/review/2679013278</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5736#discussion_r1991795477",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5736#discussion_r1991795477",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>