<p></p>
<p><b>@hlfan</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5736#discussion_r1991813305">app/assets/javascripts/osm.js.erb</a>:</p>
<pre style='color:#555'>> + mapParams.mlon = parseFloat(geoURI.lon);
+ mapParams.mlat = parseFloat(geoURI.lat);
</pre>
<p dir="auto">I'd say show a marker so later when uncertainty support is implemented in an approved way,<br>
changing L.marker to L.circle when a radius is specified in <a href="https://github.com/openstreetmap/openstreetmap-website/blob/a28f78c69a19c9c41dc96dcaad9f87cf5b530f96/app/assets/javascripts/index.js#L225">https://github.com/openstreetmap/openstreetmap-website/blob/a28f78c69a19c9c41dc96dcaad9f87cf5b530f96/app/assets/javascripts/index.js#L225</a> doesn't alter the UX too much. Otherwise it would be more confusing.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5736#discussion_r1991813305">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLMJOZCQHTYA5UQ3T7D2UBKM5AVCNFSM6AAAAABYDP55XWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMNZZGA2DGOBQGA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLJJSFRT7IRW6JUQXRT2UBKM5A5CNFSM6AAAAABYDP55XWWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTU7V33NQ.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5736/review/2679043800</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5736#discussion_r1991813305",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5736#discussion_r1991813305",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>