<p></p>
<p><b>@AntonKhorev</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5736#discussion_r1995851477">app/assets/javascripts/osm.js.erb</a>:</p>
<pre style='color:#555'>> mapParams = {};
+ [geoURI.coordstring, ...geoURI.params] = geoURI.pathname.split(";");
+ geoURI.params = Object.fromEntries([...geoURI.searchParams, ...geoURI.params.flatMap(l => [...new URLSearchParams(l)])]);
</pre>
<p dir="auto">If you're going to parse all RFC 5870 parameters, see <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2888355746" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/5736" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/5736/hovercard?comment_id=1979882902&comment_type=review_comment" href="https://github.com/openstreetmap/openstreetmap-website/pull/5736#discussion_r1979882902">#5736 (comment)</a> again. <code class="notranslate">URLSearchParams</code> is not going to work in general, try this for example <code class="notranslate">geo:48.858249,2.294541;skip=lol&z?z=19</code>.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5736#pullrequestreview-2686050874">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLIC7FGA53E6L4UMPE32UL5PNAVCNFSM6AAAAABYDP55XWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMOBWGA2TAOBXGQ">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLKUOABUPU6IXS7SLBL2UL5PNA5CNFSM6AAAAABYDP55XWWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVADHRDU.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5736/review/2686050874</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5736#pullrequestreview-2686050874",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5736#pullrequestreview-2686050874",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>