<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5809#discussion_r1997647547">lib/map_layers.rb</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,19 @@
+module MapLayers
+  def self.full_definitions(layers_filename)
+    YAML.load_file(Rails.root.join(layers_filename)).filter_map do |layer|
</pre>
<p dir="auto">This isn't actually doing any filtering it is? The block always returns a "truthy" value so a simple <code class="notranslate">map</code> would work equally well?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5809#pullrequestreview-2688730270">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLL45SYIRYZZ7GJHOKL2UWL5HAVCNFSM6AAAAABZDDHFXKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMOBYG4ZTAMRXGA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLI2JNSLN3KYJWAO27T2UWL5HA5CNFSM6AAAAABZDDHFXKWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVAILCJ4.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5809/review/2688730270</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5809#pullrequestreview-2688730270",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5809#pullrequestreview-2688730270",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>